DavyJonesLocker/postgres_ext-serializers

Support for active_model_serializers (>= 0.9.0)

rsespinosa opened this issue · 7 comments

rsespinosa commented

Is there any chance you can add active_model_serializers (>= 0.9.0) support any time soon?
Being able to use "grape-active_model_serializers" combined with "postgres_ext-serializers" would be a major win for any rails api.
Thanks and regards,

felixbuenemann commented

AMS 0.9 support shouldn't be to hard to add, but AMS 1.0 uses the JSON API serialization format and would likely require a backwards incompatible rewrite of most of the code.

rsespinosa commented

I believe AMS 0.9 support would be great, as grape-active_model_serializers has many stable versions compatible with it.
As a matter of fact, AMS 0.9 is currently the stable version, and even AMS 0.10.0 includes breaking changes for previous versions code (it's not backward compatible with 0.9.x nor 0.8.x).

felixbuenemann commented

@rsespinosa Would you like to work on a PR to add 0.9 compatibility? I've had a look at this about two weeks ago but ran out of time, so I could push my WIP branch. I've implemented most of the changes required in interfacing with the new version without breaking backwards compatibility, but there's likely still a some hours work required to get the tests to pass.

rsespinosa commented

Hi @felixbuenemann , I'm sorry for the late reply. I've been pretty complicated myself.
Sounds like a good idea. If you could please push your WIP regarding this, probably me or a member of the team can start working on this in little time.
Thanks and regards,

oyeanuj commented

@felixbuenemann @rsespinosa I was wondering if you guys are still working on AMS 0.9x support?

felixbuenemann commented

@oyeanuj I'm not actively working on it, feel free to work on the WIP branch.