DefGuard/client

Prepare signed windows binaries

Closed this issue · 5 comments

teon commented

Our CI/build is prepared for signing, but we need to modify Windows build workflow to:

  1. Sign the MSI produced (wireguard included and bundled was already signed)
  2. After exe is generated with defguard MSI (signed) and wireguard (signed) - we need to sign the EXE
  3. And release this signed exe
0rbiter commented

The current 0.4.0 windows client is not signed. Will you fix that?

teon commented

@0rbiter it is signed. Can you showcase on a screen what you mean?

0rbiter commented

It's the "windows protected you from running this software" SmartScreen warning. I might have mistaken this for signing a driver, it's just the Microsoft SmartScreen filter.
Apparently this can be prevented by submitting the application to Microsoft for malware analysis? EV or standard code signing certificates etc.
It's really irritating to users when rolling out that they receive this message and makes them question the security of the software.
protected

teon commented

We did that the day we released the version. Microsoft….

  • 👀1
0rbiter commented

Seems to work fine now, probably just took a few days for the update to come through

  • 👍1