Deltares/xmipy

Restore CI testing for Python >= 3.8 or drop older Python versions?

Closed this issue · 1 comments

mwtoews commented

CI testing for Python 3.8 and 3.9 was removed via f879240 even though this project should support python>=3.8. This lets breaking changes like #128 slip in. (The issue is only related to Python 3.8, and is a typing discrepancy related to PathLike[Any] vs PathLike). Some choices are:

  1. Restore testing the minimum supported Python version in CI.yml, which will require fixing the typing issue. If fewer Python versions are desired, then test at least the oldest and newest supported versions, e.g. 3.8, 3.10, 3.12.
  2. Or drop Python 3.8 since it will be dropped in October 2024 (PEP 569). This option should probably keep Python 3.9, as this will be around until October 2024 ([PEP 596], but it would need to be added to CI.yml.

I don't have any strong preference, so I'll let @Hofer-Julian weigh in.

Hofer-Julian commented

I don't have any strong preference, so I'll let @Hofer-Julian weigh in.

So far I always supported the last three Python versions.
But you are right, we then should also update the minimum required Python version in the pyproject.toml