Why are there dependencies?

Question

Why are there dependencies?

vikr01 opened this issue 6 years ago · 5 comments

How is this package intended to be used with node?

From what I can tell, the javascript in src is being bundled into dist with webpack and since the target is web that means those dependencies will be bundled in as well -- which means they'd only need to be devDependencies so that the user doesn't need to install it when they install the package.

Answer 1 · 2018-10-17T07:54:03.000Z

Hey @vikr01, 👋

Sorry for the delay! You are correct. Would you like to handle this one too? Thanks for your help so far, it's much appreciated! 😊

The only dependency left I guess should be just bootstrap since it's required by the main scss file only (as far as I remember) and it's not assumed to be installed. I'm not quite sure I understand what you mean with node, or that's what you were referring to?

Answer 2 · 2018-10-19T06:14:25.000Z

As far as I can see from the dist folder, there is no reference to bootstrap except in source maps. I don't think this project needs any dependencies at all.

Answer 3 · 2018-10-22T16:07:18.000Z

(sorry for the delay)

@vikr01 Oh! I see what you mean now, and you're right. 😄 Some of the dependencies are redundant, except for Bootstrap which is used here.

Answer 4 · 2018-10-23T22:10:02.000Z

@hisk That's the SCSS in src, seems that gets bundled into the CSS in dist.

Answer 5 · 2018-10-30T14:13:44.000Z

@vikr01 You are correct, but removing bootstrap is assuming that everyone is using the compiled styles only. That would force some developers that prefer to have the flexibility of compiling the assets and overriding certain styles to manually install bootstrap, which is a bit counter-intuitive.