Installation fails on Node 12
ItalyPaleAle opened this issue · 3 comments
ItalyPaleAle commented
Running npm install shards-ui fails on Node.js 12 (on macOS). There's a compilation error on iltorb, which seems to be caused by an outdated dependency (see: nstepien/iltorb#85 )
Here's the full error:
$ npm install --save shards-ui
> iltorb@1.3.10 install /Users/alessandro/Desktop/Code/platform/controller/node_modules/iltorb
> detect-libc prebuild-install || node-gyp rebuild
prebuild-install WARN install No prebuilt binaries found (target=12.1.0 runtime=node arch=x64 platform=darwin)
CC(target) Release/obj.target/iltorb/brotli/common/dictionary.o
CC(target) Release/obj.target/iltorb/brotli/dec/bit_reader.o
CC(target) Release/obj.target/iltorb/brotli/dec/decode.o
CC(target) Release/obj.target/iltorb/brotli/dec/huffman.o
CC(target) Release/obj.target/iltorb/brotli/dec/state.o
CC(target) Release/obj.target/iltorb/brotli/enc/backward_references.o
CC(target) Release/obj.target/iltorb/brotli/enc/backward_references_hq.o
CC(target) Release/obj.target/iltorb/brotli/enc/bit_cost.o
CC(target) Release/obj.target/iltorb/brotli/enc/block_splitter.o
CC(target) Release/obj.target/iltorb/brotli/enc/brotli_bit_stream.o
CC(target) Release/obj.target/iltorb/brotli/enc/cluster.o
CC(target) Release/obj.target/iltorb/brotli/enc/compress_fragment.o
CC(target) Release/obj.target/iltorb/brotli/enc/compress_fragment_two_pass.o
CC(target) Release/obj.target/iltorb/brotli/enc/dictionary_hash.o
CC(target) Release/obj.target/iltorb/brotli/enc/encode.o
CC(target) Release/obj.target/iltorb/brotli/enc/entropy_encode.o
CC(target) Release/obj.target/iltorb/brotli/enc/histogram.o
CC(target) Release/obj.target/iltorb/brotli/enc/literal_cost.o
CC(target) Release/obj.target/iltorb/brotli/enc/memory.o
CC(target) Release/obj.target/iltorb/brotli/enc/metablock.o
CC(target) Release/obj.target/iltorb/brotli/enc/static_dict.o
CC(target) Release/obj.target/iltorb/brotli/enc/utf8_util.o
CXX(target) Release/obj.target/iltorb/src/common/allocator.o
CXX(target) Release/obj.target/iltorb/src/common/stream_coder.o
CXX(target) Release/obj.target/iltorb/src/dec/stream_decode.o
../src/dec/stream_decode.cc:14:72: error: no matching member function for call to 'ToObject'
Local<Object> dictionary = Nan::Get(params, key).ToLocalChecked()->ToObject();
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/alessandro/.node-gyp/12.1.0/include/node/v8.h:2532:44: note: candidate function not viable:
requires single argument 'context', but no arguments were provided
V8_WARN_UNUSED_RESULT MaybeLocal<Object> ToObject(
^
/Users/alessandro/.node-gyp/12.1.0/include/node/v8.h:2546:35: note: candidate function not viable:
requires single argument 'isolate', but no arguments were provided
Local<Object> ToObject(Isolate* isolate) const);
^
../src/dec/stream_decode.cc:40:49: error: no matching member function for call to 'ToObject'
StreamDecode* obj = new StreamDecode(info[0]->ToObject());
~~~~~~~~~^~~~~~~~
/Users/alessandro/.node-gyp/12.1.0/include/node/v8.h:2532:44: note: candidate function not viable:
requires single argument 'context', but no arguments were provided
V8_WARN_UNUSED_RESULT MaybeLocal<Object> ToObject(
^
/Users/alessandro/.node-gyp/12.1.0/include/node/v8.h:2546:35: note: candidate function not viable:
requires single argument 'isolate', but no arguments were provided
Local<Object> ToObject(Isolate* isolate) const);
^
../src/dec/stream_decode.cc:48:35: error: no matching member function for call to 'ToObject'
Local<Object> buffer = info[0]->ToObject();
~~~~~~~~~^~~~~~~~
/Users/alessandro/.node-gyp/12.1.0/include/node/v8.h:2532:44: note: candidate function not viable:
requires single argument 'context', but no arguments were provided
V8_WARN_UNUSED_RESULT MaybeLocal<Object> ToObject(
^
/Users/alessandro/.node-gyp/12.1.0/include/node/v8.h:2546:35: note: candidate function not viable:
requires single argument 'isolate', but no arguments were provided
Local<Object> ToObject(Isolate* isolate) const);
^
../src/dec/stream_decode.cc:54:16: error: no matching member function for call to 'BooleanValue'
if (info[2]->BooleanValue()) {
~~~~~~~~~^~~~~~~~~~~~
/Users/alessandro/.node-gyp/12.1.0/include/node/v8.h:2559:8: note: candidate function not viable:
requires single argument 'isolate', but no arguments were provided
bool BooleanValue(Isolate* isolate) const;
^
/Users/alessandro/.node-gyp/12.1.0/include/node/v8.h:2562:51: note: candidate function not viable:
requires single argument 'context', but no arguments were provided
V8_WARN_UNUSED_RESULT Maybe<bool> BooleanValue(
^
../src/dec/stream_decode.cc:70:16: error: no matching member function for call to 'BooleanValue'
if (info[1]->BooleanValue()) {
~~~~~~~~~^~~~~~~~~~~~
/Users/alessandro/.node-gyp/12.1.0/include/node/v8.h:2559:8: note: candidate function not viable:
requires single argument 'isolate', but no arguments were provided
bool BooleanValue(Isolate* isolate) const;
^
/Users/alessandro/.node-gyp/12.1.0/include/node/v8.h:2562:51: note: candidate function not viable:
requires single argument 'context', but no arguments were provided
V8_WARN_UNUSED_RESULT Maybe<bool> BooleanValue(
^
5 errors generated.
make: *** [Release/obj.target/iltorb/src/dec/stream_decode.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/Users/alessandro/.nvm/versions/node/v12.1.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack at ChildProcess.emit (events.js:196:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:256:12)
gyp ERR! System Darwin 18.5.0
gyp ERR! command "/Users/alessandro/.nvm/versions/node/v12.1.0/bin/node" "/Users/alessandro/.nvm/versions/node/v12.1.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/alessandro/Desktop/Code/platform/controller/node_modules/iltorb
gyp ERR! node -v v12.1.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm WARN bootstrap@4.3.1 requires a peer of jquery@1.9.1 - 3 but none is installed. You must install peer dependencies yourself.
npm WARN bootstrap@4.3.1 requires a peer of popper.js@^1.14.7 but none is installed. You must install peer dependencies yourself.
npm WARN bootstrap@4.1.3 requires a peer of jquery@1.9.1 - 3 but none is installed. You must install peer dependencies yourself.
npm WARN bootstrap@4.1.3 requires a peer of popper.js@^1.14.3 but none is installed. You must install peer dependencies yourself.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! iltorb@1.3.10 install: `detect-libc prebuild-install || node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the iltorb@1.3.10 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
bkstorm commented
Hey guy, how about this issue?
cookieshell commented
@ItalyPaleAle Can you please provide the exact version of Node you're using while having this issue?
ItalyPaleAle commented
@cookieshell it looks like it's working now, a dependency must have been updated. It works on 12.4.0 on both macOS and Linux. Closing :)