function settingsProvider is global
Molesmalo opened this issue · 1 comments
Molesmalo commented
Hi D.
Requesting a small change on line 17:
settingsProvider = () => {
should be
let settingsProvider = () => {
As there's no var, let, const keywords, it's declared as global, thus leaking from the module.
I would also recommend adding (I forgot to add it on the examples!)
"use strict";
Thanks!
Detect commented
@Molesmalo fixed