DeterminateSystems/nuenv

Dead code in build.nu

matklad opened this issue · 2 comments

matklad commented

First time reading nu code, so I might be asking a dumb question here, but isn’t this whole if a no-op?

nuenv/nuenv/builder.nu

Line 69 in bf5a203

if not ($drv.initialPackages | is-empty) {

It seems that it prints stuff, but doesn’t actually add it to PATH?

lucperkins commented

@matklad That's actually intended to be a no-op and solely for logging purposes. The full set of packages that will be added to the PATH is determined here while the PATH is set here.

  • ❤️1
lucperkins commented

@matklad I did make a few inline docs changes that will hopefully make that more clear!