Deutsche-Digitale-Bibliothek/ddblabs-publicdomaincalculator

Author nationality

Closed this issue · 3 comments

Currently, MetaFetcherImpl does not determine the nationality of authors, which means that getNationality() will always be null. As the Answerer needs to almost always answer questions about the author's nationality, this means that no PDC questionnaire can actually be completed.

While we don't have author nationality fetchinng, it would be good to have a dummy nationality for every author. A value that the answerer would understand is "germany". I don't know if the dummy value is better set in the MetaFetcherImpl or the the PDCController - it doesn't matter much.

The ddb have only the info of birth and death place in the entity of the author

"placeOfBirth":[
                  "Frankfurt am Main"
               ],
"placeOfDeath":[
                  "Weimar"
               ]

I think the best setting of the value is the Controller or we implement a new Function, that try to find a country by the place name and the Birth date because the nationality in the past can be different than today.

Got a answer from the customer concerning this:

"> This is a bit tricky and not possible to solve only with data from DDB. Most entities (persons) at DDB are linked with Gemeinsame Normdatei (GND). If you have the GND URI (in the example of Karl Grunsky and Schornbach: http://d-nb.info/gnd/116901128) you can get some extra information using GND data directly. When you download the GND record (http://d-nb.info/gnd/116901128/about/lds) you'll get more information about places, e.g. gndo:placeOfBirth or gndo:placeOfDeath . Karl Grunsky died in „Vaihingen an der Enz“ and you'll find the URI http://d-nb.info/gnd/4062257-5 for that city in the record. If you follow it, have a look at gndo:geographicAreaCode. More about the GND ontology is here: http://d-nb.info/standards/elementset/gnd"

Any thoughts?

I implemented is with the iso 2 country code in 65f7319 , but can be easily change to human readable