Problem with help message in symphony 2.4
Closed this issue · 3 comments
In symphony 2.4 wirh image_upload 1.5, when the field is not required, optionnal is written twice in the help message.
I've just come across this as well - as the information text is a little crowded already this pushes it over the edge.
I had a poke around but couldn't work out how this text is applied, so can't contribute to a fix I'm afraid, but I'm assuming it's a simple one?
To clarify it's the i text label. So when the field isn't required, it displays, for example OptionalOptional Max width: 500px, Max height: 350px
Quick update as I'd really like to see this resolved as I'm not comfortable using it in production as-is. The bit of code that's causing the issue is here: https://github.com/vlad-ghita/image_upload/blob/master/fields/field.image_upload.php#L397-L408
If you're not using the min/max height values then this can be safely commented out. Something in that piece of logic is regenerating the Optional flag which is applied automatically. Smarter mind than mine see how?
Cracked it, fix: #22