DevDegree/eng-intern-challenge

Clarification for English pattern with number followed by lower letter

Opened this issue · 3 comments

oliviayixincai commented

It is confusing what to translate from an English pattern consisting of number followed by lower letter, such as 1a.

  • Based on the README

    When a Braille number follows symbol is read, assume all following symbols are numbers until the next space symbol.

    1a is supposed to be translated to ⠼⠁⠀⠁, which is [number follows][1][space][a]. However, if we translate it ([number follows][1][space][a]) back to English, should it be 1a or 1 a?

  • Based on test cases
    In translator.test.py, Abc 123 xYz was translated to .....OO.....O.O...OO...........O.OOOO.....O.O...OO..........OO..OO.....OOO.OOOO..OOO. Note that there is only 1 space symbol between 3 and x. This implies that for pattern like 1 a (note the space in the middle) should translate to [number follows][1][space][a], which conflicts with the aforementioned translation for 1a

To avoid confusion, please clarify how the translations should be for the cases below.

  • 1a
  • 1 a
  • 1Ab
  • 1A2
    What are the corresponding Braille for the English above?
NabilMansour99 commented

I don't think that these are valid cases as they have stated that When a Braille number follows symbol is read, assume all following symbols are numbers until the next space symbol.

That being said, the only one that is valid with this is 1 a which by doing it manually, it would be:
.O.OOO O..... ...... O..... as in number braille - braille for 1 - space braille - braille for a

tom-pj commented

@

That being said, the only one that is valid with this is 1 a which by doing it manually, it would be:
.O.OOO O..... ...... O..... as in number braille - braille for 1 - space braille - braille for a

Braille input/output should not include spaces, no?

NabilMansour99 commented

@

That being said, the only one that is valid with this is 1 a which by doing it manually, it would be:
.O.OOO O..... ...... O..... as in number braille - braille for 1 - space braille - braille for a

Braille input/output should not include spaces, no?

It shouldn't. I just placed it so it's easier to read.

  • 👍1