DevK2S/Study_Partner

Add Styled Toast

Akash-Ramjyothi opened this issue ยท 18 comments

Feature Request:

Currently, the app uses the default Toast to notify the user about certain messages. This default Toast feels too Basic and not personalized and Themed to the app. If there was a Styled and Themed Toast with respect to the app, it will make the user more comfortable to use the app.

Screenshot of Current Toast:

WhatsApp Image 2021-02-10 at 12 36 47 AM

@krayong Can I work on this issue as a part of Gssoc'21?

Hello @kunal299, @Akash-Ramjyothi is currently working on this issue. Feel free to work on any other issue or create a new issue to work on.

@krayong Thanks for assigning it to me. Will try to complete it by today.

@krayong Hey can I use any library for the styled toast or should i make it by my own?

Sure feel free to use any library as long as it doesn't increase the APK size much. Please mention the APK size in the pull request. Also if you are changing styled Toast first create a PR with screenshots of styled Toast in 1 or 2 screens let us review it and then move forward with all the screens.

This is the due date for approving the changes on at least 1 or 2 screens.

@krayong I will show it by today

@krayong Android studio doesn't capture screenshots of the toasts. So, I captured screenshot through my laptop and sharing a word file with you. If you suggest some other colors to use, I will change it.
designs of toast.docx

@krayong I think the one with the blue stroke looks good and it matches with the theme also.

I too think the one with the stroke looks cool. @ManasUniyal @priyalbhatewara123 what do you guys think?

@krayong Btw your app is awesome man.

I too think the one with the stroke looks cool. @ManasUniyal @priyalbhatewara123 what do you guys think?

Yes. Strokes one looks good.

@krayong @ManasUniyal @priyalbhatewara123Can I make a pr for this one?

Hey, since I upgraded the level from 2 to 3, it would be better if you made this change on all screens(wherever there is a toast) before creating a PR.

Hey, since I upgraded the level from 2 to 3, it would be better if you made this change on all screens(wherever there is a toast) before creating a PR.

Sure :)

@krayong Hey, I'm done with the adding of the styled toast in the whole app. Can I make a pr?

Yeah sure @kunal299 go ahead with the PR!!

@ManasUniyal @krayong @priyalbhatewara123 I have created a pr. Please review it.