Developer-DAO/create-dao

Support TypeScript

Opened this issue · 7 comments

gaslimitreached commented

It is possible to support TypeScript:

Steps:

  • create templates directory
  • rename template to default
  • move default to templates
  • create templates/typescript directory
    • will next/hardhat need separate directories due totsconfig.json?
  • update create-app.js for --typescript
    • install dependencies
    • copy templates/typescript assets

Reference for the steps above:
create-next-app

revmischa commented

Why let people make non typescript projects at all? Nobody should be doing this in 2021 imo.

  • 👎2
e-roy commented

correct, this is possible. I left code for the option of typescript install here

create-dao/index.js

Line 20 in 0709815

// .option(

and the code to copy the correct templated folder here

create-dao/create-app.js

Line 138 in 0709815

// cwd: path.join(__dirname, 'templates', template), //for seperate templated folders

I think the idea was to focus a working plain js version as a MVP and exploring ts later.

  • 👍2
carlomigueldy commented

I would volunteer to help migrate this project to TypeScript

  • ❤️3
berteotti commented

Should we add TypeScript for a template project?

revmischa commented

I would volunteer to help migrate this project to TypeScript

Go for it! Give me typescript or give me death.

  • ❤️1
e-roy commented

Changes in the file structure coming down the pipeline. This helps for smoother npm publishing and future scaling of this project if tested and merged.

Linked PR

  • ❤️1
carlomigueldy commented

Changes in the file structure coming down the pipeline. This helps for smoother npm publishing and future scaling of this project if tested and merged.

Linked PR

Nicely done, please ping me here in this issue whenever it's ready to be migrated to TypeScript and hopeful I'm not gonna interfere the development cycle