Devskiller/jfairy

Please remove groovy-all dependency from compile scope

TorstenF76 opened this issue · 0 comments

you should remove the following dependency:

<dependency>
	<groupId>org.codehaus.groovy</groupId>
	<artifactId>groovy-all</artifactId>
	<version>2.4.14</version>
</dependency>

Why?

  • It is only relevant for test, but not scoped to test. So it will transitively be included into your clients' projects.
  • There's no need to declare it explicitly, as it comes automatically with spock.
  • If there's a reason I did not see for manually upgrading the version, then you should at least set the scope to test

Thanks :-)