Move to pyright

Question

callumforrester opened this issue 4 months ago · 8 comments

Acceptance Criteria

pyproject.toml contains pyright config from https://github.com/DiamondLightSource/python-copier-template
tox -e type-checking runs pyright insead of mypy
There are no type errors

Answer 1 · 2024-09-11T10:11:26.000Z

at the moment, python-copier-template pyproject.toml does not contain references to pyright, neither does it have it as a dev dependency

Answer 2 · 2024-09-11T10:26:54.000Z

@stan-dot That is for setting up a dev environment to build/test the template, it is not the file used to make projects, you're looking for this: https://github.com/DiamondLightSource/python-copier-template/blob/main/template/pyproject.toml.jinja

Answer 3 · 2024-09-11T10:58:21.000Z

ah right, so we need to add pyright to the dev dependencies, second add

tool.pyright]
typeCheckingMode = "standard"
reportMissingImports = false # Ignore missing stubs in imported modules

third, remove mypy references

Answer 4 · 2024-09-11T11:18:45.000Z

25 errors in src, 9 errors in tests

Answer 5 · 2024-09-11T12:55:38.000Z

working on it

Answer 6 · 2024-09-11T13:35:49.000Z

sim_motor types issues - might ignore but alternatively just delete

Answer 7 · 2024-09-11T13:40:58.000Z

task worker state is also problematic

Answer 8 · 2024-09-11T13:43:52.000Z

also run engine 'run' part with the hooks is unclear