dodal.common.MsgGenerator and dls_bluesky_core.core.MsgGenerator not equal
DiamondJoseph opened this issue · 4 comments
Previously we had checked that plans were annotated with is dls_bluesky_core.core.MsgGenerator. This began causing issue, and we had to check == dls_bluesky.core.core.MsgGenerator. This now appears to also not be compatible in a built container.
It is time for a clean break and removal of dls_bluesky_core. But also a cautionary tale if we to move MsgGenerator into bluesky.
Originally posted by @DiamondJoseph in #533 (comment)
Shall we now get it all to point at the one in bluesky main: https://github.com/bluesky/bluesky/blob/7c2a44f09a747f59a17abc6cfdfe934c61c266fb/src/bluesky/utils/__init__.py#L98
Has that really been there 6 months...
There hasn't been a release since it went in. I'm chasing up now.
Closed by #832