DiederikvandenB/apollo-link-sentry

Remove peer dependencies

carlpaten opened this issue · 1 comments

Peer dependencies are for signaling that your package is a plugin for another package, but the user should provide the dependency themselves. I think it makes sense to have apollo, @sentry/browser, and possibly graphql as peer dependencies.

On the other hand, I suspect tslib and zen-observable should instead be put into dependencies. There is no reason why the user should provide them themselves. (If this is about dependency deduplication, any user who cares should leverage the resolutions field.)

Agreed, see #439