Week 6 Peer to Peer Code Review

[henask12]

Hi @dieg02587! :D, you project looks very like the design provided, great job!💪

• Nevertheless, I can suggest the following;

• Some of the hover effects are missing:

It appears that some of the expected hover effects are missing from the code. In order to enhance the user experience and provide a more visually appealing interface, it is recommended to include all the intended over effects. Consider revisiting the code to ensure that all desired over effects are implemented.

• Instead of using for loops, use for each loop:

Currently, the code employs for loops for iteration purposes. It is suggested to consider using a for each loop instead, as it offers a more concise and readable syntax. By utilizing the for each loop, you can enhance the code's clarity and reduce the risk of index-related errors.

• Minimize the usage of vw (viewport width):

The code extensively utilizes the vw unit for measurements. While vw can be useful in certain scenarios, it is important to be mindful of its potential inconsistencies across different browsers. Since the vw unit is based on the viewport width, it may result in varying visual representations on different devices and browsers. To ensure a consistent user experience, it is advisable to minimize the usage of vw and explore alternative approaches for achieving the desired responsiveness.

[General] You could make use of a code formatter such as Prettier or the like to cleanly format all HTML, CSS, js, etc code and make it more appealing to the eye as well as organized.

Overall, the markup semantics used in the CSS class naming convention looks great, as well as your -function- naming. Also, the descriptive commits messages are correct!🎯 great project partner!

@ITurres
@hajnaloltyan
@henask12