False positive `file_requires_admin` on Windows

Question

False positive `file_requires_admin` on Windows

dimitriepirghie opened this issue 3 years ago · 2 comments

On Windows OS, module pyupdater.client.updates.
file_requires_admin(file_path) function gives false positive, because open(file_path, "a+") on any process image file while it's being running always raises PermissionError exception.

Propose to use this check instead:
os.access(file_path, os.W_OK)

Answer 1 · 2021-04-28T01:06:52.000Z

@dimitriepirghie SGTM

Answer 2 · 2021-07-20T13:46:00.000Z

Hi I'm also seeing this issue, would it be possible to release the fix?