Various differences in blur, shading, or tinting
Kuuuube opened this issue · 11 comments
Describe the bug
The most recent updates have made some things look much brighter without any changes to my settings.
To Reproduce
The way I compared back to the old version of the theme was throwing the old theme from your deploy branch into my custom css while using an invalid import url in the theme settings file. To go back to the new version I removed the custom css and fixed the import url in the theme settings file.
If it helps here is my settings file (renamed to txt for upload): FrostedGlass.theme.css.txt
Screenshots
Here's a few examples of what it looks like before and after the recent updates:
Before:
After:
Before:
After:
Before:
After:
Infomation (please complete the following information)
Discord channel: Stable
OS: Windows
Mod: BetterDiscord
Discord language: English
I've also noticed that the variable --popout-modal-brightness doesn't seem to change anything that I can see while other settings such as the --popout-modal-blur does, and besides the popups mentioned above, the one you get when you right click a forum post (to say, easily follow a post or add tags) or the search suggestions is, at least with my current background, too bright, making text difficult to read, and I could not find a way to change how this appears.
I've also noticed that the variable --popout-modal-brightness doesn't seem to change anything that I can see, and besides the popups mentioned above, the one you get when you right click a forum post (to say, easily follow a post or add tags) is, at least with my current background, too bright and I could not find a way to change how this appears.
To add to this I also noticed that in the deploy branch those variables were changed but these ones don't work either
FrostedGlass/FrostedGlass.theme.css
Lines 28 to 31 in 114fcf9
FrostedGlass/FrostedGlass.theme.css
Line 52 in 114fcf9
I must've set something up incorrectly as it should just work.
I'll take a look later today.
I've also sperated the user popout and general modal/popout variables because so many people were complaining.
To further add to this, the variables for tint (--tint-colour and --tint-brightness) are currently having no effect.
Hope this helps!
It should've been fixed.
GitHub I didn't say close it!
Can confirm that tinting and pop-out variables appear to be fixed!
It should've been fixed.
Everything seems to be fixed now as far as i can tell except the popout when clicking on someone's name. Both on the right sidebar or above a message.
I also notice when switching back and forth between the versions there is a tiny change in alignment of the background image.
Here's the settings for comparison
FrostedGlass.theme.css.txt Latest version
FrostedGlass.theme.css.txt Old version from commit ff98112
The second one has the old version of FrostedGrass.css stuffed inside it instead of importing so it's easier to switch back and forth.
hey popout-modal-brightness is still not doing anything for me
Repalce --popout-modal-brightness with overlay-brightness
Closing as this appears to be completely fixed. I can't find any areas where it's broken anymore.