DmitriySalnikov/GodotPCKExplorer

[Bug]: Create pck function is broken in 1.3.1

Closed this issue · 4 comments

AG-w commented

Commit or version

1.3.1

On which operating systems the error occurs

Windows

Issue description

When you click "Pack or Embed folder", the program just frozen and do nothing

go back to 1.3.0 and it works fine

Steps to reproduce

  1. click "Pack or Embed folder"
  2. stuck at empty progress bar forever

I can only get errors if I don't delete the old files before updating.
image
But I don't have any errors if I use the clean version 1.3.1

AG-w commented

so after I use 1.3.0 to pack a pck file, 1.3.1 no longer frozen at progress bar

I noticed you added a progress bar here, but there's no progress bar in 1.3.0
2ec24ae#diff-b6a8b961aeb93b8aad9caab9c75941d3590510c5dec91e3b8c024000c6e51c54

This is just my assumption
what if you use Create pck function for the first time, that FolderPath never get initialized and it stuck at scanning empty path?

it stuck at scanning empty path?

hmm, could be related to an empty path. But I've already spent a lot of time on the frozen progress bar 😅

but there's no progress bar in 1.3.0

The progress bar was used in 1.3.0 when specifying the path, as it is now. It's just that its implementation was in the PCK creation window itself.

public void SetFolderPath(string path)

1.3.0
image

1.3.1 (it is necessary to return the counter of found files..)
image


stuck at scanning empty path

Confirmed.
Deleting the path line to the folder from the settings leads to an infinite progress bar and an error when closing it.
image