DmitryUlyanov/Multicore-TSNE

Fix compiling

domergal16 opened this issue · 5 comments

domergal16 commented

I had trouble getting this package to install, and have realized that if line 55 in setup.py is changed from:
self.cmake_args or "--",
to
self.cmake_args or "-S",

then multicore-TSNE compiles correctly. If this change could be made, that'd be awesome!

jorvis commented

This is fixed with this pull request (if it gets accepted):

#92

6884 commented

THANK YOU!!! this solved my issue as well!

r614 commented

@DmitryUlyanov thoughts on merging the fix above? PyPi installations are broken with the latest cmake, and downgrading for this library conflicts with other up-to date dependencies.

  • 👍1
JackingChen commented

this also solved my issue!

kulibour commented

THANK YOU!!!
It works!