_forms.scss should not style global button element
rodrigovallades opened this issue · 1 comments
rodrigovallades commented
Current Behavior
sass/components/forms/_forms.scss applies a global button:focus
background-color
.
button:focus {
outline: none;
background-color: $button-background-focus;
}
This makes no sense at all. We have 3 problems here:
- Why is this in
_forms.scss
and not_buttons.scss
? - _button.scss already implements a
:focus
state - This should have never been be applied to the global HTML
button
element. It should be scoped toMaterialize
, so it should be applied to the.btn
class instead - otherwise it bleeds to unintended parts of the application.
Solution
Remove this implementation from _forms.scss
and let _button.scss
do it's thing.
Environment
Version used: 1.0.0
Jerit3787 commented
Hi, this project is no longer maintained! The community-managed fork is still being maintained. Please open an issue there instead. Thanks! https://www.github.com/materializecss/materialize