Doist/reactist

Modal: Close button icon is misaligned

Closed this issue ยท 1 comments

๐Ÿ› Bug report

Current behaviour

The close modal button seems to be misaligned when used in Twist:

Screen Shot 2021-09-20 at 11 09 39 AM

Expected behaviour

The icon should be aligned

Possible solutions

Remove the following from modal.module.css:

.closeButtonIcon {
    margin-left: -4px;
    margin-top: -3px;
}

Interesting. When seen in the Reactist storybook playground, it looks ok, and removing that style you mention causes it to look wrong. I'll dig into it. I certainly would like to not need that weird style.

Update: I found the source of the issue, and worked on the fix (#567).