React-focus-lock should be a peer dependency
frankieyan opened this issue ยท 0 comments
frankieyan commented
๐ Bug report
Current behavior
It's possible for a consuming app to also have React Focus Lock installed, and if the version used in Reactist can't be deduped by npm/yarn, multiple versions can end up being bundled into the app, resulting in the two fighting for focus: https://github.com/theKashey/react-focus-lock#warning
Instead, declare it as a peer dependency so that npm/yarn can properly warn users if there is a mismatch.
Steps to reproduce the bug
Discovered while testing https://github.com/Doist/twist-web/pull/5071. If Twist is using v2.5.2, and 2.9.1 is installed with Reactist, some tests will fail.
Possible solutions
Declare React Focus Lock as a peer dependency
Environment
@doist/reactist
version: v15.0.0