Doist/reactist

Update Ariakit-utils to v0.17.0-next.23 or above to support React 17

frankieyan opened this issue ยท 1 comments

๐Ÿ› Bug report

Current behavior

Using v17.7.0 in Twist will result in webpack emitting a warning:

image

This may be fixed by ariakit-utils@v0.17.0-next.23, specifically ariakit/ariakit#1542. This will require Ariakit to be updated at least to ariakit@2.0.0-next.33. Note that next.32 has breaking changes to be aware of.

I'm not sure why the same warning isn't thrown in Todoist, which is also using React 17.0.2 and the checkbox field component.

Steps to reproduce the bug

Running Twist in dev mode results in a webpack fullscreen warning, which fails our Cypress tests

I had some issues updating to the latest ariakit@2.0.0-next.43 and ariakit-utils@0.17.0-next.27 (with ariakit-react-utils@0.17.0-next.27 added).

  • Storybook wouldn't run because an optional chaining operator appears in ariakit's esm modules. This seems to be introduced with next.42
    • ariakit dependencies will need to be transpiled
  • The menu's tests fail due to the simulated keyboard events not being able to trigger the menu. This is introduced in next.33, the version we need. The same tests pass with next.32.
    • Timers need to execute after opening the menu for focus to kick in