Doist/reactist

Remove gaps between tabs on Web

henningmu opened this issue ยท 7 comments

Description

There is an unnecessary gap between tabs in the Tab component. It seems like a 4px reactist xsmall gap. We don't need that.

Expected behaviour

Remove the gap between tabs for a more comfortable usage between them. For example in Twist's Inbox.

What needs to change

Screenshots

Before
image

After
image

Can you please elaborate the problem and also provide the path to the files in which we can work upon?

What more information apart from the screenshots and the initial issue description do you need to work on this? :)

The file is here: https://github.com/Doist/reactist/blob/main/src/tabs/tabs.tsx โ€“ my gut feeling tells me, it's the space = 'xsmall', in the TabsList that we need to remove, but would need confirmation ๐Ÿ‘

Is this issue still open?

gnapse commented

It is still open @MahirMahdi.

@gnapse Can I work on it? @henningmu is right, removing space = 'xsmall' removes unnecessary gap.

By default( with space = 'xsmall' ):

Screenshot 2023-05-31 083300

After removing space = 'xsmall':

Screenshot 2023-05-31 083519

@MahirMahdi yes, please feel free to submit a PR ๐Ÿ‘

@henningmu Thanks. On it.