If there was no cask installed, when invoking the `start --upgrade` command, new casks will never be upgraded
swissbuechi opened this issue · 6 comments
Would it harm if we would always run brew upgrade --cask -v
even if no cask is installed?
Also, aren't there formulae which cloud also require SUDO_ASKPASS
, to be auto upgraded?
Also the hint message should always be displayed, and not only when casks are already installed.
The following lines would need to be slightly updated.
start.rb
if args.upgrade?
auto_args << " && #{Autoupdate::Core.brew} upgrade --formula -v"
if (HOMEBREW_PREFIX/"Caskroom").exist?
if ENV["SUDO_ASKPASS"].nil? && !args.sudo?
opoo <<~EOS
Please note if you use Casks that require `sudo` to upgrade,
you need to use `--sudo` or define a custom `SUDO_ASKPASS`
environment variable.
EOS
end
greedy = args.greedy? ? " --greedy" : ""
auto_args << " && #{Autoupdate::Core.brew} upgrade --cask -v#{greedy}"
end
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Not stale
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
not stale
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
not stale