Doodle3D/Doodle3D-cura-plugin

Optimistic state logic issue

peteruithoven opened this issue · 2 comments

There is logic added to override the state, to optimistically assume the printer will start printing for example. But the following line prevents the api from correcting the state when this optimistic assumption was wrong.
https://github.com/Doodle3D/Doodle3D-cura-plugin/blob/master/PrinterConnection.py#L377

I would try to release the state before doing the http request
https://github.com/Doodle3D/Doodle3D-cura-plugin/blob/master/PrinterConnection.py#L351
This would allow the api to correct the state, after an override, when it starts a new request.

Mzt-t commented

There's another place where the statelock gets released:
https://github.com/Doodle3D/Doodle3D-cura-plugin/blob/master/PrinterConnection.py#L224

I've been thinking about putting the releasestatelock in a more logical place but haven't come up with the best place yet.