Download/preact-helmet

v4.0 Final

Opened this issue · 8 comments

Download commented

Inviting all active users of preact-helmet to give some feedback.

Is it ready for 4.0.0?

Please add a remark below.

Note: React-Helmet is at v5 and there is development going on to implement that. But it would be nice to release the current version as 4.0.0 before we move on imho.

ooade commented

I'll send a PR to resolve this, then we move to v4.0.0 :)

  • 🎉1
Download commented

I'm sorta hoping to get some feedback from @avaly and @siddharthkp as well.
But I agree with you probably it's good to go now.

siddharthkp commented

We're are using this on production and I think it's pretty solid.

  • 🎉1
avaly commented

I am using this in a project, but it's not yet live in production. But from the integration tests I have for it, it seems to work fine!

  • ❤️1
Download commented

Great to hear guys!

kokjinsam commented

@Download , would you be open to adding typscript definition? I can submit a PR if you want to. I'm currently using this lib with typescript in a project.

  • 👍1
kokjinsam commented

Also, is it possible to remove object-assign dependency? Users of this lib can use babel-preset-env to add polyfill.

  • 👍1
Download commented

@sammkj At the moment, object-assign is still used explicitly. I guess we would have to rewrite that code to use Object.assign... I'd be willing to change that if you make a PR.

About the Typescript definition: Definitely! Please make a PR if you will!

It would be nice to include these in v4.0.0 Final.