DreamMaoMao/hycov

Change workspaces settings for overview workspace?

Closed this issue · 41 comments

I'm trying to make it so windows have borders in the overview workspace so I can see what window is active.

I have tried using the below configuration but neither has worked, any ideas how to do it correctly?

workspace = name:OVERVIEW, border:true, bordersize:2
workspace = special:OVERVIEW, border:true, bordersize:2

a8847d2

try latest commit

workspace=name:OVERVIEW,bordersize:5

I'll give it a try in an hour and get back to you thanks!

@DreamMaoMao
After double checking the new version was loaded I can confirm it is not working.
For some extra information I am using the NixOS flake of this plugin, it is the only plugin I am currently running Hyprland with.
I tried with the below line.

workspace = name:OVERVIEW, border:true, bordersize:2

Are you sure you've updated hycov to the latest?

2024-02-07.18-49-00.mp4

it work for me

@DreamMaoMao
My flake.lock confirms the commit number and i did see the file path change in hyprland.conf.
I also restarted my whole system and regenerated the hyprland.conf
Here is the link to my hyprland configuration.
https://gitlab.com/jasper-at-windswept/dots/-/tree/main/hypr?ref_type=heads

"hycov": {
      "inputs": {
        "hyprland": [
          "hyprland"
        ]
      },
      "locked": {
        "lastModified": 1707294610,
        "narHash": "sha256-+rSTKZnVHGYBkxlL1aCA/8kR6ER7lv/uwDWfJvbSS6w=",
        "owner": "DreamMaoMao",
        "repo": "hycov",
        "rev": "a8847d230f328d4da3418bb087f22aeaa4bb3146",
        "type": "github"
      },
      "original": {
        "owner": "DreamMaoMao",
        "repo": "hycov",
        "type": "github"
      }
    },

Oh and that nix store hyprland.conf file contains this:

exec-once = /nix/store/vl5zykxl49zan3dkq8yhqfinyxg30lhh-dbus-1.14.10/bin/dbus-update-activation-environment --systemd DISPLAY HYPRLAND_INSTANCE_SIGNATURE WAYLAND_DISPLAY XDG_CURRENT_DESKTOP && systemctl --user stop hyprland-session.target && systemctl --user start hyprland-session.target
plugin=/nix/store/acivwxmgapa80d49c1wk1fpmqbmv7lb2-hycov-0.1/lib/libhycov.so
source=~/.config/hypr/hypr.conf

I think there is a bigger issue though because when I try to use one of the other options you setup rounding it also does not apply.

workspace = name:OVERVIEW, rounding:false but windows are still rounded

Just realised that wasn't a option but hard set

because i only add the bodersize rule

because i only add the bodersize rule

Hm, well i just tried again with only the bordersize rule but sadly still not working for me.

workspace = name:OVERVIEW, bordersize:20

Sorry, I have tried several Hyprland versions without any problem, maybe the problem appears in your environment, but I am not very familiar with nix

@DreamMaoMao
I'm using the latest version of Hyprland and I made sure that I was building the latest version by cloning this repository and pulling from there.

I also tried removing all my configurations except for the ones directly related to this plugin but it still is not showing borders.

Good News, I got it to work but only by hard setting the value of borderSize to 2.

https://github.com/jasper-at-windswept/hycov/commit/3809ae2ccee11617e302d822a1faf23e59bf92b2

This means that your workspace rules are not set correctly in nix, so hyprland is not reading your workspace rules

This means that your workspace rules are not set correctly in nix, so hyprland is not reading your workspace rules

Here is what i have in my nix home-manager configuration.

  wayland.windowManager.hyprland = {
    enable = true;
    package = hyprland.packages.${pkgs.system}.hyprland;
    xwayland.enable = true;
    plugins = [
      hycov.packages.${pkgs.system}.hycov
    ];
    settings = {
      source = "~/.config/hypr/hypr.conf";

      workspace = "name:OVERVIEW, bordersize:2";
    };
  };

IMG_20240208_062051.jpg

maybe like this guy.

I sourced monitors.conf from hypr.conf which was sourced from the nix generated hyprland.conf

Instead of applying the overview workspace, you might try applying the rule to another workspace to see if it works

Instead of applying the overview workspace, you might try applying the rule to another workspace to see if it works

I have tried that and yes it does work.
I can get borders on other specific workspaces.

no special workspace . try normal workspace

workspace=3,bordersize:5 like this

workspace=3,bordersize:5 like this

Yes I have tried that, it works perfectly fine for all other workspaces except the OVERVIEW one.

How about this: if your current workspace is 3,

  1. set workspace=3, bordersize: 5, and then go to overview. See if your border has any reservations under the overview.
  2. set workspace= name:3, bordersize: 5, and then go to overview. See if your border has any reservations under the overview.

overview doesn't actually change the current workspace, just change the name,

I suspect nix may have converted the OVERVIEW name from uppercase to lowercase, resulting in hyprland not being able to find the workspace corresponding to the lowercase name

1. set `workspace=3, bordersize: 5`, and then go to overview. See if your border has any reservations under the overview.

2. set `workspace= name:3, bordersize: 5`, and then go to overview. See if your border has any reservations under the overview.

@DreamMaoMao

Ok I just tried both of those for my main workspace and the borders do stay around the windows in Overview mode on that workspace.

I tried doing the below aswell but it did not work.
workspace = name:overview, bordersize:2

what? both of two setting can work?

workspace= name:3, bordersize: 5 ,This shouldn't go into effect.
if this work,That means the name didn't change before the enter overview...

are you sure you are using the latest hycov ?

it this commit i do this:

a8847d2

image

Maybe when I set name:3 it just didn't update properly.

According to my flake.lock i am using the latest commit. 69ecf80

2024-02-08.11-04-14.mp4

As you can see in the video, the name changes after entering the ov mode so the name:3 rule is invalid

The simplest solution i can see here is just enabling border_size = 2 by default and then disabling borders on all work spaces one by one like below.

I have double checked hyprctl layers and the overview layer is fully capitalized there and in Waybar but for some reason I can't access it using workspace rules.

workspace = 1, monitor:DP-2, default:true, border:false
workspace = 2, monitor:DP-2, border:false
workspace = 3, monitor:DP-2, border:false
workspace = 4, monitor:DP-1, border:false
workspace = 5, monitor:DP-1, border:false
workspace = 6, monitor:DP-1, border:false

This has nothing to do with case, because according to the results of previous tests, the name of the workspace did not change before entering ov mode.

image

Can you show me your log, see if he changed his name before entering

image

Can you show me your log, see if he changed his name before entering

Where can I find that log.sh?

#!/usr/bin/bash

a=$(cd /tmp/hypr/ && ls -rt | tail -1)
tail -f /tmp/hypr/$a/hyprland.log

bash tool/log.sh | grep -E "workspace|enter"

#!/usr/bin/bash

a=$(cd /tmp/hypr/ && ls -rt | tail -1)
tail -f /tmp/hypr/$a/hyprland.log

bash tool/log.sh | grep -E "workspace|enter"

That returns the error below
And yes i made sure to add that disable_logs = false and rebooted my system

tail: cannot open '/tmp/hypr/a6ccd36147109d5cb2981122595f06ae93999b55_1707365755.lock/hyprland.log' for reading: Not a directory
tail: no files remaining

Then you can go to this directory and find the latest date dir manually

/tmp/hypr/

@DreamMaoMao
After checking the logs it looks the same as what you sent.

[LOG] [hycov] enter overview
[LOG] renameWorkspace: Renaming workspace 1 to 'OVERVIEW'
[LOG] [hycov] enter overview:alt switch mode auto next
[LOG] renameWorkspace: Renaming workspace 1 to '1'

cdec254

please try this and show me again

please try this and show me again

./log.sh | grep -E "workspace|enter|change to"

[LOG] [hycov] enter overview
[LOG] renameWorkspace: Renaming workspace 1 to 'OVERVIEW'
[LOG] [hycov] change to layout:ovgrid
[LOG] [hycov] enter overview:alt switch mode auto next
[LOG] renameWorkspace: Renaming workspace 1 to '1'

everything look goo, sorry i have no idea what happen to you .