DrylandEcology/rSOILWAT2

Package not installing due to Rfprintf error

Closed this issue · 6 comments

PAckage fails to install on both my mac and on the Linux HPC...

This is the error:

SW_Site.c:700:3: warning: implicit declaration of function 'Rfprintf' is invalid in C99 [-Wimplicit-function-declaration]
                swfprintf(logfp, "\n");
                ^
./generic.h:130:21: note: expanded from macro 'swfprintf'
  #define swfprintf Rfprintf
                    ^
1 warning generated.
SW_VegProd.c:610:3: warning: implicit declaration of function 'Rfprintf' is invalid in C99 [-Wimplicit-function-declaration]
                swfprintf(logfp, "\n");

fixed with #121

That branch isn't passing all the checks. Do you recommend I use it now anyway?

When you check why the test on appveyor is failing you will see that

Complete output:
  > library("testthat")
  Error: package or namespace load failed for 'testthat':
   package 'testthat' was installed by an R version with different internals; it needs to be reinstalled for use with this R version
  Execution halted
* DONE

So, this is an appveyor/testthat problem and not a rSOILWAT2 problem.

See content of .gitmodules: branch = bugfix_177
That is, if you run the normal git submodule update --remote (see README), then it will pull the correct version of `SOILWAT2.

@CaitlinA Is this issue resolved for you? If so, can you please close it?