Duder-onomy/svelte-focus-trap

Svelte resolve configuration warning.

olafurw opened this issue · 2 comments

I was building my project and got this warning.

13:20:01 [vite-plugin-svelte] WARNING: The following packages use a svelte resolve configuration in package.json that has conflicting results and is going to cause problems future.

svelte-focus-trap@1.2.0

Please see https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#conflicts-in-svelte-resolve for details.

@olafurw I was able to put together a PR that should fix this issue.

#9

I think this should solve things as it is now a Sveltekit Library and the Svelte version resolution should be fixed.

If you wanted to give that PR a try I would appreciate it.

I am going to merge it in a few days.

Full rewrite, nice. I'll check it when it appears in my NPM, but I stopped getting a warning when vite-plugin-svelte fixed a normalization issue.

sveltejs/vite-plugin-svelte#634