[Feature]: Add new land variable handlers for supporting ILAMB
chengzhuzhang opened this issue · 8 comments
Is your feature request related to a problem?
As discussed at meetings with land developers, right now only a subset of ilamb required variables can be handled by zppy through e3sm_to_cmip. @dmricciuto provided a conversion table that from CLM2 /home/ac.ricciuto/models/ilamb_processing/alm2ilamb_wkflow/clm_to_mip
I don’t know if the listed variables are still relevant. Before implementing into e3sm_to_cmip, we need a land develop to have a review. @thorntonpe hey Peter, could you recommended someone? We get multiple requests from land team to produce more CMIP variables from zppy. Pinging, @hydrotian @evasinha @daliwang @qzhu-lbl ...
As a reference, here listed land variables we already supported.
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
@chengzhuzhang I am happy to help with the review. Please let me know how you want me to proceed.
@chengzhuzhang I have added additional land variables to the table.
@evasinha Thanks! Could you also take care removing duplicated entries from row 28, and resolve conflict formula? I notice for example LAI has different conversion formula somehow. Finally I realized the original table missed a unit column. It would be great if you can add it.
I met today with Nate Collier (part of the iLAMB team) to get the full list of variables that they need, the units they expect, and the descriptions of the variables. I am iterating with him on a couple outstanding questions, and then I will compare my notes against the table linked above. I have a note that some help is needed generating the variable handlers in e3sm_to_cmip. Once we have the full list of iLAMB variables confirmed I can circle back to that. Note that there will be a difference between the variables we want for time series and mapped diagnostics, and the ones needed for iLAMB. I should be able to provide more feedback after confirming the iLAMB list.
@thorntonpe thanks for the updates!
Regarding to the list of variables for time series and maps, the variables put together for mapps generated by e3sm_diags was from a separate practice. For the time series plots in zppy, we can try generating some prioritized land variables and to generalize for more if needed.
- I have removed duplicate rows where there was no conflict in formula. When the formula were different I have kept the duplicate row but added a note saying different formula.
- I have added a column for CMIP units.
@evasinha Thank you for updating the table! We will be able to start the code change once get reviewed and confirmed by Peter.