EC-DIGIT-CSIRC/sysdiagnose

[Bug] Fix decoding of bytes in the plist cleaning functions

Closed this issue · 2 comments

Today its handled with

d[k]=binascii.hexlify(v).decode('utf-8')

But it should handle differently outputs from the plist module

  • Data
  • UiD

depending on the data it output with b' or b"

Maybe reading the code of the plist module would figure out how they handle different classes.

I think this is already covered now with the changes I made ensuring all plists are loaded through the load_plist_file_as_json() function that uses the json_serializable() function for decoding.

@kwouffe can you please check and confirm?

I think this is now addressed since the use of the nska_deserialize library.