EDOMH Integration
jixxed opened this issue · 11 comments
Request for integration with the odyssey materials helper
https://github.com/jixxed/ed-odyssey-materials-helper
recently implemented in EDSY: taleden/EDSY@2dd2981
works by creating a url that contains compressed json base64 encoded in the format:
edomh://coriolis/?
json follows the format:
{
"version":1,
"name":"ship build name",
"items": [
{
"item": "Hpt_BeamLaser_Fixed_Small",
"blueprint": "Weapon_Efficient",
"grade": 5,
"highestGradePercentage":0.8
},
{
"item": "Hpt_BeamLaser_Fixed_Small",
"blueprint": "special_weapon_damage"
}
]
}
experimental effect do not require the grade and highestGradePercentage fields.
only blueprints and experimental effects need to included in the json, no modules.
the url can then be embedded on the site and contains all the information to construct a wishlist in the app.
hi! I looked at the schema you have, and was wondering if it'll be compatible with SLEF
Not sure what SLEF is, but the json is limited to blueprints only. Adding more data can result in urls that exceed the 2KB limit. I can make customizations to the format. To include rolls per grade for example, as long as they are limited to integers. Or to leave out highestGradePercentage if it is unused in coriolis.
Currently there are discrepancies in the data that is sent over. 1 example is LifeSupport_LightWeight which should be Misc_LightWeight. (Also very unlikely the ship has 3 life support systems)
there may be other discrepancies.
Also the armor is not properly sent over and is missing mandatory fields:
tested on beta:
button stays disabled, can't export.
Trying to do this myself and the "Send to EDOMH" button is available if EDEngineer API is running but the request fails. Maybe this isn't yet implemented in EDOMH?
Support for it has been disabled in EDOMH since issues mentioned were never fixed.
Support for it has been disabled in EDOMH since issues mentioned were never fixed.
Support for it has been disabled in EDOMH since issues mentioned were never fixed.
Quite happy to pick this up if you wish to continue the integration?
Support for it has been disabled in EDOMH since issues mentioned were never fixed.
Support for it has been disabled in EDOMH since issues mentioned were never fixed.
Quite happy to pick this up if you wish to continue the integration?
Sure, let me know if you have any questions
Now in testing with @jixxed to confirm duplicate blueprints are resolved, misnamed blueprints are resolved and mat miscalculation is resolved. There is still an issue with the fact that Coriolis cannot currently export to EDOMH with an accurate percentage for the grade of the blueprint, as that data doesn't seem to be gathered properly (or is not easily identifiable) in the process of building the 'ship' data ready for the export... I will address this separately, as most people will simply build to 100% of a grade when 'planning' a build.
Coriolis will now be able (following successful PR to develop for beta.coriolis.io and then main after testing for coriolis.io) to export to EDOMH with the ship name and type correctly, without repeating modules if the blueprints are set to <G5 with the right 'item name' for Armour modules and the button to export to EDOMH no longer requires EDEngineer to be running
Fixes and improvements deployed to live site