EGiunchiglia/C-HMCNN

Confused about transpose of constraint matrix

utkutpcgl opened this issue · 1 comments

utkutpcgl commented

Thanks for your work!
For the output of get_constr_out to be correct, should not we take the transpose of the constraint matrix? The constrain matrix contains the ancestors at the last dimension, however, we want an ancestor to take the maximum of its descendants.

C-HMCNN/main.py

Line 27 in ae80265

def get_constr_out(x, R):

EGiunchiglia commented

Hi! Sorry for the delayed reply.

I checked it and there were misleading comments in the main file. I have now changed them (plus I have added further clarifications). Let me know if that helps :)