ELH-mk1/sta2e

Compatibility of modules for prior version

Opened this issue · 5 comments

Orlanth-Rex commented

Just to note that there are a couple of key modules that don't work with this iteration of the system:

  • STA Initiative;
  • Compendia for STA;
  • STA System Enhancements
ELH-mk1 commented

I hadn't heard of these before now! Lemme see...

  • The STA Initiative likely just needs a few tweaks to work with this system, but I don't manage that repo. I'll reach out to @CoolcatFVTT and see if they're still updating things
  • The Compendia requires a complete rebuild for 2E anyways, so that's to be expected
  • The STA System Enhancements is another situation where I don't control the repo. Still, I'll reach out to @WesWedding
WesWedding commented

I didn't know my module was getting used by anyone yet. 😅

That said, I'm happy to collaborate! We should see how things actually break; it could be that it makes more sense for me to be the one supporting THIS project and not the other way around, considering I'm trying to improve upon the original system.

CoolcatFVTT commented

I'm not maintaining STA Initiative anymore. Simply haven't got the time to do it properly....and I haven't touched FoundryVTT for 2 years. Feel free to fork and take over. Note that there are already a number of forks I'm aware of:

@WesWedding @mprangenberg @CraftyAF

WesWedding commented

Did a quick check just to see how things failed and there's definitely no chance that STA2E can change to address this issue. STA Enhanced is built extending the STACharacterSheet class which means it is highly coupled with the original system (and all of its expected game settings).

E.g.
Error: An error occurred while rendering STACharacterEnhancedSheet 23. "sta.characterAttributeLimitIgnore" is not a registered game setting

The fix would have to be on the Plugin side, conditionally extending STA2E classes instead as a start.

ELH-mk1 commented

Did a quick check just to see how things failed and there's definitely no chance that STA2E can change to address this issue. STA Enhanced is built extending the STACharacterSheet class which means it is highly coupled with the original system (and all of its expected game settings).

E.g. Error: An error occurred while rendering STACharacterEnhancedSheet 23. "sta.characterAttributeLimitIgnore" is not a registered game setting

The fix would have to be on the Plugin side, conditionally extending STA2E classes instead as a start.

The good news is that all you should have to do to address that is change the sta. to sta2e.
I kept a large majority of the settings/classes the same, with as few changes as necessary to get things to work.

I'm not maintaining STA Initiative anymore. Simply haven't got the time to do it properly....and I haven't touched FoundryVTT for 2 years. Feel free to fork and take over. Note that there are already a number of forks I'm aware of:

Thanks for the heads up! I'll look into these forks and see if I can either work with them or bring their code over so the module is native to the system.