ENikS/LINQ

GroupBy typing incorrect

Closed this issue · 7 comments

MgSam commented

The typing on GroupBy is not correct. It is currently defined as this:

GroupBy<K, E, R>(selKey: (x: T) => K, selElement?: (x: T) => E, selResult?: (a: K, b: Iterable<E>) => R): Enumerable<R>;

It should return an IGrouping<K, R> instead.

ENikS commented

Do you want to send a PR?

MgSam commented

Done. Let me know if any issues.

ENikS commented

Thank you

MgSam commented

@ENikS We just realized we actually need the linq-es5 package instead. Do you have to do anything special to publish an updated version of that package with the changes I committed?

ENikS commented

Just send me another pull request, I'll deploy it

MgSam commented

@ENikS I see there's a bunch of differences in linq.ts between the two branches. Is that intentional or has master just not been merged into linq-es5 in a while?

ENikS commented

It is intentional