$qProvider.errorOnUnhandledRejections(false)
Yankovsky opened this issue · 8 comments
Hi! Great lib. Can you explain what is the purpose of this line?
cancellableModule.config(['$qProvider', function($qProvider){
$qProvider.errorOnUnhandledRejections(false);
}]);
@Yankovsky If I remember my debugging correctly, this resolves an error that Angular v1.5.9+ throws when used with ui-router. See this thread for more info.
However, thank you for the note. I'll review that code to see if that is still necessary. 👍
I am not sure that is it responsibility of this lib to take care of ui-router integration. I want to use your lib but I am afraid of such side effects.
@Yankovsky I'm looking into removing that now. As I'm digging in, I remembered it's not a ui-router specific issue, but a general Angular issue. I'm attempting to remove it now, but it could take a while. If you have ideas on how to properly fix this, please feel free to contribute via comments or a PR
@Yankovsky I believe I've fixed it. If you're willing to checkout the develop branch, it'd be nice to have a tester before pushing the changes to the npm registry
Thank you! I'll check it out.
I want to integrate your lib with mine https://github.com/Yankovsky/angular-promise-debounce to create ultimate DebouncedCancellableHttp promises :)
@Yankovsky Looks pretty cool. Any report on how those updates worked out for you? If it's good, I'll go ahead and merge master and update npm
Merged updates into master and published update to npm