Change defaults

Question

Change defaults

Closed this issue 8 years ago · 8 comments

Don't you need to change https://github.com/meetearnest/eslint-config-earnest-es7/blob/master/index.js#L50 and https://github.com/meetearnest/eslint-config-earnest-es7/blob/master/index.js#L51 to "either" per standard/standard#182?

niftylettuce commented 8 years ago

haha what

Answer 1 · 2016-05-10T21:00:20.000Z

I meant 0 for off***

Answer 2 · 2016-05-11T17:17:14.000Z

yjhuoh commented 8 years ago

Answer 3 · 2016-05-11T17:41:06.000Z

I can close this, I extended it with my own rules, but I thought these were different from standard, not sure, haha

Answer 4 · 2016-05-11T17:42:36.000Z

Thanks for the feedback @niftylettuce. Will look into it.

Answer 5 · 2016-05-25T17:54:42.000Z

I think @niftylettuce's proposal is reasonable and in line with how we treat spaces in array literals. I suggest we change object-curly-spacing to 0.

@moredip, @jsatk what say you?

Answer 6 · 2016-05-25T18:03:26.000Z

@bromanko I agree. Sounds good to me.

Answer 7 · 2016-05-25T19:00:45.000Z

Fine with me.
On May 25, 2016 11:07 AM, "Jesse Atkinson" notifications@github.com wrote:

@bromanko https://github.com/bromanko I agree. Sounds good to me.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#16 (comment)