EbbLabs/python-tidal

Item type 'DEEP_LINK' not implemented

Opened this issue · 6 comments

I used high-tide master with tidalapi 0.8.5 and when loading the new homepage I get this error. It does not load. I suspect the message is triggerd by this:

raise NotImplementedError(f"Item type '{item_type}' not implemented")

The json_obj appears to be just this

{
    "title": "My Tracks",
    "id": "tidal://my-collection/tracks",
    "url": "tidal://my-collection/tracks"
}

I have My Tracks in recently played, so maybe that is where this is from.

It is probably better just to give a warning in case an item type is not implemented, although this one should be pretty straightforward (it is just an URL to a separate page that can be followed).

Will fix in the next release.

Maybe reopen this until it the type is implemented?

As far as I can tell, currently these links are only used for the "My Tracks" playlist. Maybe an initial implementation could check if the uri is the same an then just fetch the playlist from the collection.

As far as I can tell, currently these links are only used for the "My Tracks" playlist. Maybe an initial implementation could check if the uri is the same an then just fetch the playlist from the collection.

I did not get these item types earlier. So I have not been able to add an implementation.

But from the path, it looks like a simple URL to a different page. Similar to the "view more" link that can be clicked. So I think the implementation should be straightforward.

If you get something working, feel free to make a (draft) PR so we can add support for additional page types.