EddyVerbruggen/barcodescanner-lib-aar

Between 2.0.1 and 2.1.0 barcode scanning speed (at least for CODE_39) has decreased on android

joshstrange opened this issue · 3 comments

iOS has no issue but Android is noticeably slower. Every once in awhile it will pick it up right away but most of the time you can see the barcode clear as day and it won't pick it up. I use this library through using the cordova barcode scanning library and noticed the decrease going from 6.0.3 and 6.0.4. I have tried the latest version of this library in cordova and it still exhibits the same issues.

I went ahead and branched 2.0.2 and the merged in your torch toggle commits, built the .aar, moved it into the cordova barcode scanner library, and then it all worked (fast scanning but the ability to toggle the torch and start with the torch on).

https://github.com/corrisoft/barcodescanner-lib-aar/tree/fast (<- Nothing special here just for reference)

I also went ahead and bundled it all up if anyone else needs it:

[ionic | cordova | phonegap] plugin add https://github.com/corrisoft/phonegap-plugin-barcodescanner.git  --variable CAMERA_USAGE_DESCRIPTION="To scan barcodes" --save

Well it appears I tried to run before I could walk. I'd wager there is an issue with 6.0.5 that I didn't check for as I was testing with 6.0.4 so I'll need to take a look at that but that won't happen until at least monday.

Ok, this comment #7 (comment) is now valid. It is working correctly with the latest cordova plugin and there is no speed loss.