[SDCARD] SD cards without labels
pfeerick opened this issue · 2 comments
I think a side effect of this test is that SD cards that haven't had a label set won't appear in the drop down? I can understand the mounted part, that's part and parcel of doing stuff on Linux, but requiring a label is going to be annoying unless the requirement is clearly stated. i.e. I never bothered setting a volume label for the SD that came with my T-Lite, and it didn't appear in the list - so I just had to set one after reviewing the code to work out why it didn't show. I can't say for certain I noticed the problem on Windows - I'll have to try again with another unlabelled card to check.
flasher/src/components/SDCardPage.vue
Line 263 in 879a715
Just verified it's also happening on Windows, so it will be because of that filter. It may be better to drop that requirement, and possibly also add the size of the drive to the dropdown, thus if a system drive is included in the list by accident (which generally shouldn't because of the removable requirement, the end user can eliminate by size.
The filter has been removed so it should work fine now, please re-open if it wasn't solved.