EionRobb/purple-googlechat

compiled/installed, but make warnings

Opened this issue · 1 comments

I compiled but got some warnings, and it compiled/installed, but I'd already copied & pasted these, so leaving them here in case they're useful in the future.

mozai commented

Also saw warnings. purple-googlechat r494.1e89ad9-1

googlechat_auth.c: In function ‘googlechat_auth_get_dynamite_token_cb’:
googlechat_auth.c:320:27: warning: argument 1 null where non-null expected [-Wnonnull]
  320 |         gint expires_in = atoi(json_object_get_string_member(obj, "expiresIn"));
      |                           ^~~~
/usr/include/stdlib.h:362:1: note: in a call to function ‘atoi’ declared ‘nonnull’
  362 | __NTH (atoi (const char *__nptr))
      | ^~~~~
googlechat_events.c: In function ‘googlechat_got_http_image_for_conv’:
googlechat_events.c:269:9: warning: ‘g_memdup’ is deprecated: Use 'g_memdup2' instead [-Wdeprecated-declarations]
  269 |         image = purple_image_new_from_data(g_memdup(response_data, response_size), response_size);
      |         ^~~~~
googlechat_events.c:270:9: warning: ‘g_memdup’ is deprecated: Use 'g_memdup2' instead [-Wdeprecated-declarations]
  270 |         image_id = purple_image_store_add(image);
      |         ^~~~~~~~
googlechat_conversation.c: In function ‘googlechat_got_buddy_photo’:
googlechat_conversation.c:1079:9: warning: ‘g_memdup’ is deprecated: Use 'g_memdup2' instead [-Wdeprecated-declarations]
 1079 |         response_dup = g_memdup(response_str, response_len);
      |         ^~~~~~~~~~~~
purple2compat/http.c: In function ‘purple_http_request_set_contents’:
purple2compat/http.c:2637:9: warning: ‘g_memdup’ is deprecated: Use 'g_memdup2' instead [-Wdeprecated-declarations]
 2637 |         request->contents = g_memdup(contents, length);
      |         ^~~~~~~