Elders/VSE-FormatDocumentOnSave

Partial matches on extensions

blkbam opened this issue · 12 comments

blkbam commented

allowed_extensions = .cs
denied_extensions = .*

Having the setup above will match on .css files as well which I'm assuming is because of a partial match. A work around has been to just do:

allowed_extensions = .cs
denied_extensions = .css .*

mynkow commented

Omg, this is bad. I will check. Thanks for reporting this

  • 🎉1
mynkow commented

I just tested this and I am experiencing the following:

With configuration:
allowed_extensions = .cs
denied_extensions = .*

cs files are formatted
css files are not formatted

Am I missing the point @blkbam ?

blkbam commented

hmm. seems that it is working for me now also. sorry about that. i'll play with it a bit more to see if I can reproduce it more but for now let's close this.

mynkow commented

Sure, feel free to reopen this issue if you face the problem again. I am also trying something

mynkow commented

Actually, I was able to reproduce it

blkbam commented

cool! glad to know i wasn't seeing things.

mynkow commented

@blkbam I am able to reproduce it only if the denied_extensions is left empty and allowed_extensions = .cs. This falls into example 5

However, if I add .* to the denied_extensions and allowed_extensions = .cs it is working properly.

Could you please check the version of the extension

blkbam commented

I may have had it set up like that initially. I'm using 1.24.

blkbam commented

i did start explicitly listing extensions in the denied list so that we can track which ones will be added to the allow list as we fix it's formatting.

For example:

denied_extensions = .css .html .*

mynkow commented

Could you please give it one more try with your initial configuration:

allowed_extensions = .cs
denied_extensions = .*
blkbam commented

that one does work as expected

mynkow commented

Perfect. Feel free to reopen this if you face any issues.