Election-Tech-Initiative/electionguard-ui

๐Ÿž Remove eslint disable for useEffect on JointKeySelectStep.ts:72

Closed this issue ยท 1 comments

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The eslint warning on line 72 of JointKeySelectStep.ts says that the ceremonyClient hook should be included in the dependencies array for useEffect. However, when you include it, then React creates an infinite loop of calls to ceremonyClient.find:

image

The infinite loop does not occur if the call to ceremonyClient.find doesn't setKeyCeremonies. Also the infinite loop does occur if you pass in pretty much any value into the dependencies list, not just ceremonyClient.

Remove the eslint disable and fix the underlying problem so the infinite loop doesn't occur.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- OS:

Anything else?

No response

This will not be worked or considered for 1.0. A new issue will be created if needed in the future.