Reintroduce carpet patch with a config
Anchor5178 opened this issue · 5 comments
Since 923ff1f was reverted with 5b5762f this issue is existing again.
This could be easily fixed by making https://github.com/Electroid/SportPaper/blob/master/patches/server/0191-Prevent-1.7-players-glitching-in-carpet.patch toggleable via the config.
Only AAC5 users have to disable this patch. AAC5 does not even support 1.7 so AAC5 users do not need this patch.
Or maybe you can use ViaVersion API to know if the player is using 1.7.
I do not understand how that should fix this issue since pure 1.8 servers are affected by it even though they do not need it.
I do not understand how that should fix this issue since pure 1.8 servers are affected by it even though they do not need it.
Didn't it only affect 1.7 clients?
No, it also affects 1.8 players since the carpet height is set to 0 for all players.
With the patch, the hitbox is handled client-side, if you set it to 0 all players can freely walk on it, 1.7 players (due to their client) will be on y=0, and 1.8+ players will (again, due to their client) walk on y=0.0625.
The complaint is some anticheats will not treat this properly