Port KDE theme to KDE 6
dr460nf1r3 opened this issue · 12 comments
KDE 6 is hitting soon, so the theme needs to be ported to KDE 6 to work. While the desktop theme works, the SDDM theme is broken and refuses to load due to failing QML imports. I'm testing this on Garuda Linux via KDE master branch builds.
Thanks for the great work 🥇
Thanks for the great work.
I already started working on porting my kde stuff to plasma 6 :)
Here are some plasma docs to port to plasma6
https://develop.kde.org/docs/plasma/theme/theme-porting-to-plasma6/
https://develop.kde.org/docs/plasma/widget/porting_kf6/
I've added the initial port of the SDDM theme https://github.com/EliverLara/Sweet/tree/dark-plasma-6/kde/sddm if anyone could test it and see whether something is missing or not working would be great
Re: SDDM - I gave it a try and saw no issues, though a few warnings in the console. I am on Arch with KDE Plasma 6 (Wayland) and Nvidia proprietary drivers.
$ sddm-greeter-qt6 --test-mode --theme /usr/share/sddm/themes/Sweet/
High-DPI autoscaling Enabled
Reading from "/usr/local/share/wayland-sessions/plasma.desktop"
Reading from "/usr/share/wayland-sessions/plasma.desktop"
Reading from "/usr/local/share/xsessions/plasmax11.desktop"
Reading from "/usr/share/xsessions/plasmax11.desktop"
Loading theme configuration from "/usr/share/sddm/themes/Sweet//theme.conf"
Socket error: "QLocalSocket::connectToServer: Invalid name"
Loading file:///usr/share/sddm/themes/Sweet//Main.qml...
kf.svg: The theme "Sweet" uses the legacy metadata.desktop. Consider contacting the author and asking them update it to use the newer JSON format.
kf.svg: The theme "Sweet" uses the legacy metadata.desktop. Consider contacting the author and asking them update it to use the newer JSON format.
kf.plasma.core: The theme "Sweet" uses the legacy metadata.desktop. Consider contacting the author and asking them update it to use the newer JSON format.
kf.plasma.core: The theme "Sweet" uses the legacy metadata.desktop. Consider contacting the author and asking them update it to use the newer JSON format.
file:///usr/share/sddm/themes/Sweet//Main.qml:351:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
file:///usr/share/sddm/themes/Sweet//Login.qml:93:9: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
file:///usr/share/sddm/themes/Sweet//Login.qml:21: ReferenceError: units is not defined
file:///usr/share/sddm/themes/Sweet//KeyboardButton.qml:19: TypeError: Cannot read property 'longName' of undefined
file:///usr/share/sddm/themes/Sweet//Main.qml:320: ReferenceError: units is not defined
file:///usr/share/sddm/themes/Sweet//Login.qml:21: ReferenceError: units is not defined
Adding view for "eDP-1" QRect(0,0 1707x1067)
kf.svg: The theme "Sweet" uses the legacy metadata.desktop. Consider contacting the author and asking them update it to use the newer JSON format.
qt.qml.context: file:///usr/share/sddm/themes/Sweet//Login.qml:82:9 Parameter "event" is not declared. Injection of parameters into signal handlers is deprecated. Use JavaScript functions with formal parameters instead.
qt.qml.context: file:///usr/share/sddm/themes/Sweet//Main.qml:96:9 Parameter "event" is not declared. Injection of parameters into signal handlers is deprecated. Use JavaScript functions with formal parameters instead.
qt.qml.context: file:///usr/share/sddm/themes/Sweet//Main.qml:199:17 Parameter "username" is not declared. Injection of parameters into signal handlers is deprecated. Use JavaScript functions with formal parameters instead.
Reading from "/usr/share/wayland-sessions/plasma.desktop"
QIODevice::write (QLocalSocket): device not open
^CSignal received: SIGINT
In test mode, everything scales according to my Plasma 6 (Wayland) settings, but at startup it is HiDPI but doesn't seem to scale. I tried copying the config files as described in Arch Wiki but that didn't seem to help. I did discover there were a couple of known issues (which will be patched soon?) in both KDE and SDDM but I think they are specific to Wayland and my SDDM is starting up in X11 mode before transferring to Plasma 6 Wayland session on login. In any case, I don't think they are related to the theme, but I thought I would mention them in case they were relevant to you or someone else.
Hope this helps. Thank you for your hard work on these excellent themes!
P.S. The previous version I installed through the KDE theme settings definitely did not work -- I got a blank screen with mouse pointer. It took me a while to figure out what was going on, but eventually I tried the test-mode command on that one and it gave an error about the wrong QtQuick.Controls being the wrong version. That's how I ended up here. :)
Update: I guess I spoke too soon, the HiDPI scaling is working fine now after I've rebooted a few times.
There are a few "glitches" in the Plasma style that should be improved IMO.
- User switcher - it is stretched a lot (don't mind the different background of the icon, it's edited. The stretching happens on vanilla Sweet as well)
- Drop-down menus - there is a subtle line at the top of every drop-down menu that looks quite out of place. I'm not sure whether this is a design choice since these are also used in other places, but to me, it looks off.
- User switcher - it is stretched a lot (don't mind the different background of the icon, it's edited. The stretching happens on vanilla Sweet as well)
@dr460nf1r3 Could you try with the latest change in the plasma theme, please?
- Drop-down menus - there is a subtle line at the top of every drop-down menu that looks quite out of place. I'm not sure whether this is a design choice since these are also used in other places, but to me, it looks off.
That's due to the separator(line.svg) color, it used to be dark but it was changed in order to solve this and this, Do you think it should be a little bit dark?
Of course!
It certainly looks much better, although there could be less spacing between the elements. As a reference, here is the dropdown of the system tray:
I hope this doesn't come across as being too nitpicky 😅
That's due to the separator(line.svg) color, it used to be dark but it was changed in order to solve EliverLara/Sweet-kde#45 and EliverLara/Sweet-kde#39, Do you think it should be a little bit dark?
Ah! That explains it. Making it darker should be a good middle ground between having the issue you fixed before via that line and having it stand out in the dropdowns.
Hello there, after upgrading to Fedora 40, I couldn't find Sweet theme in the theme list of KDE, but the icon theme and some other settings are applied already. Splash and SDDM are not used though, I have downloaded Sweet.zip from here and extracted it inside /usr/share/sddm/theme but still I am getting an issue saying couldn't find main.qml.
Hi, is this work still ongoing? Is it possible to assist in any way beta testing?