Quantity elements should not be input field

Question

Quantity elements should not be input field

Closed this issue 5 years ago · 4 comments

georgebutter commented 7 years ago

With input fields, we have to wrestle with the user agent styling of text and number inputs.

Answer 1 · 2017-10-24T23:27:29.000Z

Interesting idea! A fallback would be more difficult.

Answer 2 · 2017-10-31T11:54:43.000Z

A fallback would be more difficult

In what way?

Answer 3 · 2017-11-05T00:16:15.000Z

If it falls back to an input field, the users can still add quantities without requiring JS. Maybe that doesn't matter though, what were you thinking the replacement would be?

Answer 4 · 2017-11-06T05:56:37.000Z

Good point, I mostly don't like it being a number field. User agent styling on some browsers has not been reset and you get the up and down buttons. But it also shouldn't really be a text field/editable.
Could use noscript as a fallback but that is ugly...

I don't want Cartfox to have to rely on an input field value either, on ajax templates it doesn't make much sense to be able to edit the number.