Elkfox/shopify-theme-framework

Duplicated logo settings

Closed this issue · 3 comments

Cam commented

We currently have duplicated settings for logos. This needs a cleanup, as does the way we define meta images like opengraph, favicon and itemprop sources.

It looks like "favorites_pinned_svg" isn't defined yet either.

I think this should take the form of settings for both a bitmap and svg image to be applied dynamically per use.

This sounds good! Do you have a recommend structure for the fav images I know there are supposed to be lots of different dimensions.

@ButsAndCats this is a good guide for Favicons: https://github.com/joshbuchea/HEAD

As implemented in RC

Cam commented

+1 ...that's literally my go to